Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete device_role field from REST API serializer for device model #15292

Closed
jeremystretch opened this issue Feb 27, 2024 · 0 comments
Closed

Remove obsolete device_role field from REST API serializer for device model #15292

jeremystretch opened this issue Feb 27, 2024 · 0 comments
Assignees
@jeremystretch
Labels
breaking change This change modifies or removes some previously documented functionality status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

jeremystretch commented Feb 27, 2024 •
edited
Loading

Proposed Changes

Drop the device_role property from the Device model, and the field from DeviceSerializer. (It has been superseded by role.)

Justification

The model field was renamed to role under #6391 in v3.6; this field was retained on the serializer for backward compatibility.

Impact

Any REST API clients which still reference the device_role field must be updated to use the role field, which contains the same data (and is writable).
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior labels Feb 27, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Feb 27, 2024
@jeremystretch jeremystretch self-assigned this Feb 29, 2024
jeremystretch added a commit that referenced this issue Feb 29, 2024
@jeremystretch
Closes #15292: Remove obsolete device_role attribute from Device model
da4af35
@jeremystretch jeremystretch mentioned this issue Feb 29, 2024
Merged
jeremystretch added a commit that referenced this issue Mar 1, 2024
@jeremystretch
Closes #15292: Remove obsolete device_role attribute from Device model
709eac6
jeremystretch added a commit that referenced this issue Mar 6, 2024
@jeremystretch
Changelog for #12795, #15277, #15292
7567c9d
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
@jeremystretch jeremystretch added the breaking change This change modifies or removes some previously documented functionality label May 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
breaking change This change modifies or removes some previously documented functionality status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch