Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Source custom fields are not available through REST API #14879

Closed
amyasnikov opened this issue Jan 20, 2024 · 0 comments · Fixed by #14895
Closed

Data Source custom fields are not available through REST API #14879

amyasnikov opened this issue Jan 20, 2024 · 0 comments · Fixed by #14895
Assignees
@jeremystretch
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@amyasnikov
Copy link
Contributor

Deployment Type

Self-hosted

NetBox Version

v3.7.1

Python Version

3.10

Steps to Reproduce

  1. Create custom field and assign it to Data Source.
  2. Create Data Source and fill out respective custom field via GUI.
  3. Try to get the information about created Data Source through REST API - there will be no "custom_fields" field.
  4. If you try to create Data Source through REST API "custom_fields" field will be ignored.

Expected Behavior

There should be consistency in interaction with Data Sources (or any other model). If a user can assign custom fields to this model through web GUI, then the same opportunity should also exist for REST API.

All that's required to do for this issue is just add "custom_fields" here
https://github.com/netbox-community/netbox/blob/develop/netbox/core/api/serializers.py#L37

Observed Behavior

Neither reading nor changing "custom_fields" value for a Data Source is available through REST API.
@amyasnikov amyasnikov added the type: bug A confirmed report of unexpected behavior in the application label Jan 20, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: medium Results in substantial degraded or broken functionality for specfic workflows labels Jan 22, 2024
@jeremystretch jeremystretch self-assigned this Jan 22, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jan 22, 2024
jeremystretch added a commit that referenced this issue Jan 22, 2024
@jeremystretch
Fixes #14879: Include custom fields in REST API representation of dat…
851b941 
…a sources
@jeremystretch jeremystretch mentioned this issue Jan 22, 2024
Merged
jeremystretch added a commit that referenced this issue Jan 22, 2024
@jeremystretch
Fixes #14879: Include custom fields in REST API representation of dat…
cd8e977 
…a sources
jeremystretch added a commit that referenced this issue Jan 22, 2024
@jeremystretch
Changelog for #14572, #14847, #14879, #14885, #14892
e4188b5
@jeremystretch jeremystretch mentioned this issue Feb 5, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
2 participants
@amyasnikov @jeremystretch