Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Add Tags field in the bulk edit form is not limited by the object types setting on the tag #13376

Closed
kkthxbye-code opened this issue Aug 4, 2023 · 0 comments
Closed

The Add Tags field in the bulk edit form is not limited by the object types setting on the tag #13376

kkthxbye-code opened this issue Aug 4, 2023 · 0 comments
Assignees
@jeremystretch
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@kkthxbye-code
Copy link
Contributor

NetBox version

v3.6.0-beta1

Python version

3.10

Steps to Reproduce

  1. Create a tag tag1 with the object types set to DCIM > Device
  2. Create a site site1
  3. Edit site1 and observe that the tags list does not contain tag1
  4. Go to the site list, select the checkbox to the left of site1 and press Edit Selected
  5. Open the Add tags or Remove tags select field

Expected Behavior

The select field should not contain tag1

Observed Behavior

The select field contains tag1

The implementation just looks at the name of the field, which doesn't work as the names of the fields are add_tags and remove_tags:

https://github.com/netbox-community/netbox/pull/12982/files#diff-e5b671e6922772660da9b89ea1d237483d2ebbd9bec451079b32fa22b09b8840R38-R39

Also, I don't believe that the bulk edit form inherits from NetBoxModelForm so the code is not touched anyway.
@kkthxbye-code kkthxbye-code added type: bug A confirmed report of unexpected behavior in the application beta Concerns a bug/feature in a beta release labels Aug 4, 2023
@jeremystretch jeremystretch self-assigned this Aug 4, 2023
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Aug 4, 2023
jeremystretch added a commit that referenced this issue Aug 4, 2023
@jeremystretch
Fixes #13376: Restrict add/remove tag fields by model on bulk edit forms
12f496e
@jeremystretch jeremystretch mentioned this issue Aug 4, 2023
Merged
@jeremystretch jeremystretch added the severity: low Does not significantly disrupt application functionality, or a workaround is available label Aug 4, 2023
jeremystretch added a commit that referenced this issue Aug 4, 2023
@jeremystretch
Fixes #13376: Restrict add/remove tag fields by model on bulk edit forms
f1c182b
jeremystretch added a commit that referenced this issue Aug 9, 2023
@jeremystretch
Changelog for #12814, #13037, #13376, #13410
ff59845
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kkthxbye-code @jeremystretch