Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update table headers to use gettext #13150

Closed
arthanson opened this issue Jul 11, 2023 · 0 comments
Closed

Update table headers to use gettext #13150

arthanson opened this issue Jul 11, 2023 · 0 comments
Assignees
@arthanson
Labels
topic: Internationalization type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.6

Comments

@arthanson
Copy link
Collaborator

Proposed Changes

In order to correctly support internationalization, table fields need to be audited and make sure all strings are using gettext.

Note: Splitting the internationalization work of similar model, forms, tables into separate issues as they are quite large and don't effect each other.

Justification

Table fields need their labels use gettext for internationalization.
@arthanson arthanson added type: housekeeping Changes to the application which do not directly impact the end user topic: Internationalization labels Jul 11, 2023
@arthanson arthanson added this to the v4.0 milestone Jul 11, 2023
@arthanson arthanson self-assigned this Jul 11, 2023
@arthanson arthanson mentioned this issue Jul 25, 2023
Merged
jeremystretch added a commit that referenced this issue Jul 31, 2023
@arthanson @jeremystretch
Closes #13150: Wrap table column headers with gettext()
e284cd7 
Co-authored-by: Jeremy Stretch <[email protected]>
@jeremystretch jeremystretch changed the title Update table fields to use gettext Update table headers to use gettext Aug 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
@jeremystretch jeremystretch modified the milestones: v4.0, v3.6 Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

Labels
topic: Internationalization type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.6
Development

No branches or pull requests
2 participants
@arthanson @jeremystretch