-
Notifications
You must be signed in to change notification settings - Fork 1k
Contributes 6 new device types for Nokia SR Linux product line #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* D1 (management switch) * D2/D2L * D3/D3L * H3 All systems come in AC and DC variants, with airflow Front-2-Back or Back-2-Front
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for your contribution! Please review the requested changes and let me know if you have any questions. In the meantime I am going to mark this PR as a draft, and once you are ready you can mark it ready for review and ping me if desired.
* model fans and power modules as separate module-types, including airflow variations * update slug to include 'nokia-' * remove comments Note that 'weight' information is not available in the datasheets
Looks like the system does not allow 'airflow' attribute for fan modules, but these modules do have a specific airflow direction - it is essential to their existence Could we update Netbox to allow airflow attributes for modules? Submitted an issue: netbox-community/netbox#11969 |
Yup I agree, for the time being to get this PR moving, could you just create the modules without airflow? You could also add a comment with the airflow direction so that once this is possible we can retroactively go back and fix these |
Hey @jbemmel I would recommend adding Let me know if you need help with this. If you would like me to work on this with you, please send me an invite to your fork |
Just a reminder the positions need to be strings, so you need to write them as |
* Renumber modules to match system config IDs (starting at 1) * Remove space from name
… into nokia-srlinux
…x-community#1189) * Contribute 6 new device types for Nokia SR Linux product line: * D1 (management switch) * D2/D2L * D3/D3L * H3 All systems come in AC and DC variants, with airflow Front-2-Back or Back-2-Front * Updated in response to feedback: * model fans and power modules as separate module-types, including airflow variations * update slug to include 'nokia-' * remove comments Note that 'weight' information is not available in the datasheets * Comment out 'airflow' attribute for the time being * * Add 'position' to module bays * Renumber modules to match system config IDs (starting at 1) * Remove space from name * Be consistent in mgmt interface naming, it's 'mgmt0' --------- Co-authored-by: Daniel W. Anner <[email protected]>
All systems come in AC and DC variants, with airflow Front-2-Back or Back-2-Front. Now modeled as separate PSU/FAN modules with airflow attribute (to be discussed/added)