Skip to content

Contributes 6 new device types for Nokia SR Linux product line #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 14, 2023
Merged

Contributes 6 new device types for Nokia SR Linux product line #1189

merged 11 commits into from
Mar 14, 2023

Conversation

jbemmel
Copy link
Contributor

@jbemmel jbemmel commented Mar 10, 2023

  • D1 (management switch)
  • D2/D2L
  • D3/D3L
  • H3

All systems come in AC and DC variants, with airflow Front-2-Back or Back-2-Front. Now modeled as separate PSU/FAN modules with airflow attribute (to be discussed/added)

* D1 (management switch)
* D2/D2L
* D3/D3L
* H3

All systems come in AC and DC variants, with airflow Front-2-Back or Back-2-Front
Copy link
Member

@danner26 danner26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your contribution! Please review the requested changes and let me know if you have any questions. In the meantime I am going to mark this PR as a draft, and once you are ready you can mark it ready for review and ping me if desired.

@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label Mar 12, 2023
@danner26 danner26 marked this pull request as draft March 12, 2023 18:01
jbemmel and others added 2 commits March 13, 2023 10:56
* model fans and power modules as separate module-types, including airflow variations
* update slug to include 'nokia-'
* remove comments

Note that 'weight' information is not available in the datasheets
@jbemmel
Copy link
Contributor Author

jbemmel commented Mar 13, 2023

Looks like the system does not allow 'airflow' attribute for fan modules, but these modules do have a specific airflow direction - it is essential to their existence

Could we update Netbox to allow airflow attributes for modules? Submitted an issue: netbox-community/netbox#11969

@jbemmel jbemmel marked this pull request as ready for review March 13, 2023 16:07
@danner26
Copy link
Member

Yup I agree, for the time being to get this PR moving, could you just create the modules without airflow? You could also add a comment with the airflow direction so that once this is possible we can retroactively go back and fix these

@jbemmel jbemmel requested a review from danner26 March 13, 2023 17:23
@danner26
Copy link
Member

danner26 commented Mar 13, 2023

Hey @jbemmel I would recommend adding position to the module-types. When a module references {module} it will use what is in the position definition
For example if your module interface/port is - name: PSU{module} and you install it to a bay with position: 3, you will end up with PSU3

Let me know if you need help with this. If you would like me to work on this with you, please send me an invite to your fork

@danner26
Copy link
Member

Just a reminder the positions need to be strings, so you need to write them as '1'

@danner26 danner26 added status: accepted and removed status: revisions needed This issue requires additional information to be actionable labels Mar 14, 2023
@danner26 danner26 merged commit 0259087 into netbox-community:master Mar 14, 2023
@jbemmel jbemmel deleted the nokia-srlinux branch March 14, 2023 13:45
etherwrangler pushed a commit to etherwrangler/devicetype-library that referenced this pull request Jul 16, 2023
…x-community#1189)

* Contribute 6 new device types for Nokia SR Linux product line:
* D1 (management switch)
* D2/D2L
* D3/D3L
* H3

All systems come in AC and DC variants, with airflow Front-2-Back or Back-2-Front

* Updated in response to feedback:

* model fans and power modules as separate module-types, including airflow variations
* update slug to include 'nokia-'
* remove comments

Note that 'weight' information is not available in the datasheets

* Comment out 'airflow' attribute for the time being

* * Add 'position' to module bays
* Renumber modules to match system config IDs (starting at 1)
* Remove space from name

* Be consistent in mgmt interface naming, it's 'mgmt0'

---------

Co-authored-by: Daniel W. Anner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants