Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub workflow files #1224

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Update GitHub workflow files #1224

merged 4 commits into from
Dec 30, 2024

Conversation

bakgaard
Copy link
Contributor

Breaking change

No breaking changes

Proposed change

  • Reenable ci_analyze.yml when merging into main
  • Add GitHub Actions to dependabot
  • Update all Actions to latest major version

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

@helto4real
Copy link
Collaborator

Thanks a lot!! Love these kinds of contributions. I will do a proper review tomorrow after work.

@bakgaard
Copy link
Contributor Author

bakgaard commented Dec 29, 2024

No rush.

It all comes down to getting rid of warnings when building.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82%. Comparing base (51b2d09) to head (d8707b6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1224   +/-   ##
====================================
  Coverage    82%     82%           
====================================
  Files       196     196           
  Lines      3840    3840           
  Branches    426     426           
====================================
  Hits       3159    3159           
  Misses      516     516           
  Partials    165     165           
Flag Coverage Δ
unittests 82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this!

@helto4real
Copy link
Collaborator

helto4real commented Dec 30, 2024

@bakgaard please make sure the commits are signed for better security. I let this one pass for now since it was an easy review.
image
https://docs.github.com/authentication/managing-commit-signature-verification/about-commit-signature-verification

@helto4real helto4real merged commit 5c0bf09 into net-daemon:main Dec 30, 2024
7 of 8 checks passed
@bakgaard
Copy link
Contributor Author

Odd, I thought it was.
I will fix it for future commits.

helto4real pushed a commit that referenced this pull request Feb 4, 2025
* Update a few GitHub actions' versions, and add dependabot to check for latest version of GitHub actions

* Update SonarScan for .NET
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants