Hassmodel APIs creates entities of types created by nd-codegen #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1188 +/- ##
====================================
Coverage 82% 82%
====================================
Files 193 196 +3
Lines 3790 3820 +30
Branches 425 428 +3
====================================
+ Hits 3132 3162 +30
Misses 491 491
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
helto4real
approved these changes
Oct 17, 2024
| var entityClasses = EntitiesGenerator.Generate(entityDomains); | ||
| var serviceClasses = ServicesGenerator.Generate(orderedServiceDomains); | ||
| var extensionMethodClasses = ExtensionMethodsGenerator.Generate(orderedServiceDomains, entityDomains); | ||
|
|
||
| return new[] { helpers, entityClasses, serviceClasses, extensionMethodClasses }.SelectMany(x => x).ToArray(); | ||
| return [..helpers, entityFactory, ..entityClasses, ..serviceClasses, ..extensionMethodClasses]; |
There was a problem hiding this comment.
Just love this syntax!
helto4real
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Added GeneratedEntityFactory * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When using nd-codegen the HassModel API's can now return entities of the generated types. So you can eg do
var allLights = haContext.GetAllEntities().OfType()
Type of change
Additional information
Checklist
If user exposed functionality or configuration are added/changed: