Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability fixes #1131

Merged
merged 30 commits into from
Jul 6, 2024
Merged

Stability fixes #1131

merged 30 commits into from
Jul 6, 2024

Conversation

helto4real
Copy link
Collaborator

@helto4real helto4real commented Jul 4, 2024

Breaking change

Proposed change

Some quality and stability fixes.

  • Make the dispose of application context thread safe
  • Correct sample of use calendar in debug project
  • Make the handling of usage of cancellation token that could potentially be used from a disposed or canceled Cancellation token source, check screenshot
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 78.78788% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81%. Comparing base (089f848) to head (53bafb5).
Report is 1 commits behind head on main.

Files Patch % Lines
....Extensions.MqttEntityManager/MessageSubscriber.cs 0% 7 Missing ⚠️
...aemon.Extensions.Scheduling/DisposableScheduler.cs 78% 0 Missing and 4 partials ⚠️
...Deamon.HassModel/Internal/BackgroundTaskTracker.cs 66% 3 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1131   +/-   ##
====================================
  Coverage    81%     81%           
====================================
  Files       191     190    -1     
  Lines      3865    3887   +22     
  Branches    464     474   +10     
====================================
+ Hits       3163    3187   +24     
+ Misses      520     518    -2     
  Partials    182     182           
Flag Coverage Δ
unittests 81% <78%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helto4real helto4real enabled auto-merge (squash) July 6, 2024 19:38
@helto4real helto4real disabled auto-merge July 6, 2024 19:38
@helto4real helto4real enabled auto-merge (squash) July 6, 2024 19:38
@helto4real helto4real merged commit 4a3cbb5 into main Jul 6, 2024
7 checks passed
@helto4real helto4real deleted the some-fixes branch July 6, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants