Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housecleaning #1108

Merged
merged 2 commits into from
May 26, 2024
Merged

Housecleaning #1108

merged 2 commits into from
May 26, 2024

Conversation

helto4real
Copy link
Collaborator

Breaking change

Proposed change

Going through and make house cleaning to make sure we use the latest language features and cleaner code

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 72.97297% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81%. Comparing base (55a74e5) to head (5fcbbb2).

Files Patch % Lines
...t/Extensions/IHomeAssistantConnectionExtensions.cs 60% 0 Missing and 2 partials ⚠️
...Model/NetDaemon.HassModel.CodeGenerator/Program.cs 0% 2 Missing ⚠️
...n.AppModel/Internal/Config/ConfigurationBinding.cs 66% 1 Missing ⚠️
...etDaemon.HassClient/Internal/Helpers/HttpHelper.cs 0% 1 Missing ⚠️
...mon.HassClient/Internal/Net/WebSocketClientImpl.cs 0% 1 Missing ⚠️
...sClient/Internal/Net/WebSocketTransportPipeline.cs 50% 0 Missing and 1 partial ⚠️
....Extensions.MqttEntityManager/MessageSubscriber.cs 0% 1 Missing ⚠️
...etaData/ServicesMetaData/StringAsArrayConverter.cs 0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1108   +/-   ##
====================================
  Coverage    81%     81%           
====================================
  Files       188     188           
  Lines      3752    3743    -9     
  Branches    450     450           
====================================
- Hits       3058    3051    -7     
+ Misses      515     513    -2     
  Partials    179     179           
Flag Coverage Δ
unittests 81% <72%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helto4real helto4real marked this pull request as ready for review May 25, 2024 13:58
@FrankBakkerNl FrankBakkerNl merged commit 7f6be19 into main May 26, 2024
7 checks passed
@FrankBakkerNl FrankBakkerNl deleted the optimizations branch May 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants