Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@nestjs/swagger): replace quoted functionPlaceholder completely #1963

Merged
merged 2 commits into from
Jul 11, 2022
Merged

fix(@nestjs/swagger): replace quoted functionPlaceholder completely #1963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2afc3dc
fix(@nestjs/swagger): replace quoted functionPlaceholder completely
Panzer1119 Jul 8, 2022
5c38773
test(@nestjs/swagger): add manual test for 2afc3dcbf3ff69b5382306a68d…
Panzer1119 Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions e2e/manual-e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,16 @@ async function bootstrap() {
}
});

SwaggerModule.setup('/swagger-docs', app, document, {
customSiteTitle: 'Demo API - Swagger UI 3',
swaggerOptions: {
persistAuthorization: true,
defaultModelsExpandDepth: -1,
tagsSorter: (a, b) => a.localeCompare(b),
operationsSorter: (a, b) => a.get('id').localeCompare(b.get('id'))
}
});

USE_FASTIFY
? (app as NestFastifyApplication).useStaticAssets({
root: publicFolderPath,
Expand Down
2 changes: 1 addition & 1 deletion lib/swagger-ui/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function buildJSInitOptions(initOptions: SwaggerUIInitOptions) {
2
);

json = json.replace(new RegExp(functionPlaceholder, 'g'), () => fns.shift());
json = json.replace(new RegExp('"' + functionPlaceholder + '"', 'g'), () => fns.shift());

return `let options = ${json};`;
}