Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): when updating a non-existing nestjs module #1447

Merged
merged 2 commits into from
Jun 14, 2023
Merged

fix(utils): when updating a non-existing nestjs module #1447

merged 2 commits into from
Jun 14, 2023

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Jun 13, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #1444

What is the new behavior?

if there's no uncomment occurrence of @Module, only the import statement will be added:

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 96efd13 into nestjs:master Jun 14, 2023
@kamilmysliwiec
Copy link
Member

LGTM

@micalevisk micalevisk deleted the fix/issue-1444 branch June 14, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error when invoking 'generate module' and there's no nestjs module to update
2 participants