style: fix minor formatting problems, add void to bootstrap function #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed redundant spaces in .eslintrc.js, jsconfig.json added "void" to a bootstrap function call as WebStorm complains to it being async function and ignoring the returned promise
|
Nice |
micalevisk
reviewed
Dec 11, 2022
| @@ -5,4 +5,4 @@ async function bootstrap() { | |||
| const app = await NestFactory.create(AppModule); | |||
| await app.listen(3000); | |||
| } | |||
| bootstrap(); | |||
| void bootstrap(); | |||
There was a problem hiding this comment.
using void like this isn't common for user-facing nodejs project. Instead, I guess we should ignore lintting errors on application/files/**/*.{js,ts} files
There was a problem hiding this comment.
Yeah, I don't think we should use void here either
There was a problem hiding this comment.
ok, removed
left only formatting issues fixes
micalevisk
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add "void" to a bootstrap function call as WebStorm complains to it being async function and ignoring the returned promisePR Checklist
PR Type
What is the current behavior?
WebStorm complains about calling asynchronous bootstrap function (main.ts) and ignoring the promise returned from it.
What is the new behavior?
voidoperator makes the expression return undefined so we explicitly ignore the top-level promise frombootstrap.Does this PR introduce a breaking change?