fix: middleware sort issues

nestjs · Jan 27, 2025 · 58fcd88 · 58fcd88
1 parent 08fce4a
commit 58fcd88
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/core/middleware/middleware-module.ts b/packages/core/middleware/middleware-module.ts
@@ -150,13 +150,17 @@ export class MiddlewareModule<
       ([moduleA], [moduleB]) => {
         const moduleARef = this.container.getModuleByKey(moduleA)!;
         const moduleBRef = this.container.getModuleByKey(moduleB)!;
-        if (moduleARef.distance === Number.MAX_VALUE) {
+        const isModuleAGlobal = moduleARef.distance === Number.MAX_VALUE;
+        const isModuleBGlobal = moduleBRef.distance === Number.MAX_VALUE;
+        if (isModuleAGlobal && isModuleBGlobal) {
+          return 0;
+        }
+        if (isModuleAGlobal) {
           return -1;
         }
-        if (moduleBRef.distance === Number.MAX_VALUE) {
+        if (isModuleBGlobal) {
           return 1;
         }
-
         return moduleARef.distance - moduleBRef.distance;
       },
     );