-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency axios to v1 #572
Conversation
c8efe78
to
9c8f851
Compare
Anything preventing this PR being merged? We would like to upgrade to Axios V1 but have this as a dependency |
Any news about this PR ? Same as @erichardson30, we're waiting to update |
Oops! I created a PR for this too > #579 Sorry |
9c8f851
to
5033056
Compare
Whats the state? Around 2 weeks past now 👀 |
Are there any breaking changes? |
There were breaking changes, improves etc... in axios so not sure why we're waiting for v1 of nestjs/axios package. It's the easiest way to unblock everyone who is interested in and not block others by minor (?) update which could lead to situation when someone will notice that it contains major/breaking change and v1 will be inevitable 😂 |
@Dzixxx I'm just wondering if there are any changes needed in the |
@kamilmysliwiec I guess that patches for v1 will be the easiest way because of lack of tests in the package 😅 Probably each of us (interested in axios update in this repo) will be more than happy to create PR with some fixes instead of waiting (at least me 😂). From typings perspective seems to be fine (IDE was not screaming) 😆 |
PRs are more than welcome @Dzixxx 🙌 |
So far so good, npm build script works so ... v1 then? 😂 |
This PR contains the following updates:
0.27.2
->1.1.3
Release Notes
axios/axios
v1.1.3
Compare Source
Added
Fixed
Chores
Contributors to this release
v1.1.2
Compare Source
Fixed
Contributors to this release
v1.1.1
Compare Source
Fixed
Contributors to this release
v1.1.0
Compare Source
Fixed
Contributors to this release
v1.0.0
Compare Source
Added
Changed
Deprecated
Removed
Fixed
Chores
Security
Contributors to this release
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.