Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix media query style is lost when it's compiled #1105

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

kitimark
Copy link
Contributor

@kitimark kitimark commented Feb 3, 2024

Description

fix invalid test spec should compile template with the handlebars adapter with enabled css-inline and media query.

this test case want to keep style but actual is not keep it.
in @css-inline/css-inline lib, we have to add data-css-inline="keep" for keep it after complied.

example:

<head>
  <!-- Styles below are not removed -->
  <style data-css-inline="keep">h1 { color:blue; }</style>
</head>
<body>
  <h1>Big Text</h1>
</body>

ref: https://github.com/Stranger6667/css-inline?tab=readme-ov-file#configuration

Change

  • upgrade version @css-inline/css-inline to 0.13.0
  • fix should compile template with the handlebars adapter with enabled css-inline and media query test

if you have a question. please feel free to ask.

@kitimark kitimark changed the title test: fix media query style loss when it's compiled test: fix media query style is lost when it's compiled Feb 3, 2024
@juandav juandav merged commit 13ed63d into nest-modules:main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants