Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download ckb_aarch64 for neuron-arm64 #2627

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

Keith-CY
Copy link
Collaborator

@Keith-CY Keith-CY commented Apr 4, 2023

This PR packages ckb_aarch64 in Neuron-arm64 and ckb_x86_64 in Neuron-x64
image

Please notice that macos-11 is specified in .github/workflows/package_for_test.yml in this PR for testing, it should be specified to macos-12 or macos-latest as mentioned in Magickbase/neuron-public-issues#123, but many irrelative work may be introduced, so it's left for further development.

Ref: Magickbase/neuron-public-issues#93

@Keith-CY Keith-CY force-pushed the download-ckb-arm64-for-neuron-arm64 branch from 81e4cf2 to 6daa63a Compare April 4, 2023 11:34
@Keith-CY Keith-CY force-pushed the download-ckb-arm64-for-neuron-arm64 branch from 6daa63a to 3fb4fbb Compare April 4, 2023 12:24
@Keith-CY Keith-CY marked this pull request as ready for review April 4, 2023 13:21
@Keith-CY Keith-CY changed the title feat: download ckb_aarch64 for neuron-arch64 feat: download ckb_aarch64 for neuron-arm64 Apr 5, 2023
@Keith-CY
Copy link
Collaborator Author

Keith-CY commented Apr 6, 2023

Please have a review @WhiteMinds @JeffreyMa597 @devchenyan

@Keith-CY Keith-CY merged commit 085e1f2 into develop Apr 6, 2023
@Keith-CY Keith-CY deleted the download-ckb-arm64-for-neuron-arm64 branch April 6, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants