Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use batch rpc to request result. Optimization sql search. #2530

Merged
merged 4 commits into from
Jan 5, 2023
Merged

fix: Use batch rpc to request result. Optimization sql search. #2530

merged 4 commits into from
Jan 5, 2023

Conversation

yanguoyu
Copy link
Collaborator

  1. For the nerovs dao page, there are many rpc requests, use batch request.
  2. Because some users have many relations with others cells, left join twice to search inputs and outputs.
  3. Find unlock transactions with the status that equal Dead or Pending.

@yanguoyu yanguoyu mentioned this pull request Nov 19, 2022
Closed
Cedar67
Cedar67 approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@Cedar67 Cedar67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the changes to the ckb architecture, this PR needs to be validated after being merged into the develop branch.

@yanguoyu
fix: Use batch rpc to request result. Optimization sql search.
f56995d 
1. For the nerovs dao page, there are many rpc requests, use batch request.
2. Because some users have many relations with others cells, left join twice to search inputs and outputs.
3. Find unlock transactions with the status that equal Dead or Pending.
@yanguoyu
fix: Add test case and optimize some logic
fa1ffd3
@yanguoyu
fix: Fix typo.
3c4fc26
@yanguoyu
Copy link
Collaborator Author

Due to the changes to the ckb architecture, this PR needs to be validated after being merged into the develop branch.

I have rebased develop.

@yanguoyu yanguoyu merged commit 1f2d884 into nervosnetwork:develop Jan 5, 2023
@yanguoyu yanguoyu deleted the fix-batch-rpc branch January 5, 2023 03:00
@Cedar67
Copy link
Contributor

Cedar67 commented Jan 9, 2023

Verified on develop branch.

This was referenced May 27, 2023
Merged
Merged
@0xfather 0xfather mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@Cedar67 Cedar67 Cedar67 approved these changes

@alexsupa597 alexsupa597 alexsupa597 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanguoyu @Cedar67 @Keith-CY @alexsupa597