Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use large timeout value for integration test #954

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

quake
Copy link
Member

@quake quake commented Jun 5, 2019

Change all waiting_for_sync timeout value to 60 seconds, resolve integration test fail issue on poor CI server.

@quake quake requested a review from a team June 5, 2019 06:22
@nervos-bot
Copy link

nervos-bot bot commented Jun 5, 2019

@yangby-cryptape is assigned as the chief reviewer

@chaoticlonghair
Copy link
Contributor

In this version, some tests wait 60 secs for 5 height, and some tests wait 60 secs for 2 height, it seems not fair.

IMHO, a more flexible solution is: check if there is anything changed in a small interval.

Didn't reach the target? That's OK, if there is some changes in each interval, it means the program is still alive.

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #954 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #954   +/-   ##
=======================================
  Coverage     57.7%   57.7%           
=======================================
  Files          171     171           
  Lines        17230   17230           
=======================================
  Hits          9942    9942           
  Misses        7288    7288
Impacted Files Coverage Δ
test/src/node.rs 0% <0%> (ø) ⬆️
test/src/specs/tx_pool/pool_reconcile.rs 0% <0%> (ø) ⬆️
test/src/specs/sync/chain_forks.rs 0% <0%> (ø) ⬆️
test/src/net.rs 0% <0%> (ø) ⬆️
test/src/specs/relay/compact_block.rs 0% <0%> (ø) ⬆️
test/src/specs/relay/transaction_relay.rs 0% <0%> (ø) ⬆️
test/src/specs/tx_pool/pool_resurrect.rs 0% <0%> (ø) ⬆️
test/src/specs/sync/sync_timeout.rs 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c38856c...d7cd76c. Read the comment docs.

@doitian doitian merged commit 41ea649 into develop Jun 5, 2019
@doitian doitian deleted the quake/waiting_for_sync branch June 5, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants