feat: make a better error message for miner when method not found #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doitian is assigned as the chief reviewer |
|
CI status of the fork branch is |
|
Should we exit the miner program after logging the warning message? |
I have considered that, and I found that you can just restart your |
chaoticlonghair
force-pushed
the
pr/miner-method-not-found
branch
from
28370b8 to
e2af9a4
Compare
doitian
approved these changes
Jun 1, 2019
keroro520
approved these changes
Jun 1, 2019
doitian
changed the title
This was referenced Jun 3, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #904.