feat: add indexer related rpc #905
Conversation
|
@xxuejie is assigned as the chief reviewer |
There was a problem hiding this comment.
A more general comment: personally I feel like this module shouldn't belong to CKB core, but right now we don't have a good way to keep it out of core. Should we get the chance to refactor CKB with plugin support, we should move this out of core and only works as a CKB plugin.
util/jsonrpc-types/src/wallet.rs
Outdated
| #[derive(Serialize, Deserialize)] | ||
| pub struct CellTransaction { | ||
| pub created_by: TransactionPoint, | ||
| pub consumed_by: Option<TransactionPoint>, |
There was a problem hiding this comment.
I'm not sure if the name here makes sense, a transaction consumes cells, not transaction, and yet here we have a transaction that is consumed by many other transactions. CellTransaction is also an interesting name here.
|
@xxuejie most review issues have been resolved, others are open for discussion, please review again, thanks. |
![nervos-bot[bot]](https://avatars.githubusercontent.com/in/22976?s=60&v=4){kind=small}
quake
force-pushed
the
quake/wallet
branch
3 times, most recently
from
7b4fd4a to
e06ab0b
Compare
|
Conflicted |
|
How to handle schema migration? The main database stores the version into the database to check compatibility. |
Currently, there are no version checking in the indexer store, I would like to refactor version and corruption checking of rocksdb to an utility function in future PR. |
This PR added 5 indexer related rpc, most lines of code are unit / integration test and document, core logic is in indexer/src/store.rs