Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: secp256k1 multisig #891

Merged
merged 1 commit into from
May 28, 2019
Merged

feat: secp256k1 multisig #891

merged 1 commit into from
May 28, 2019

Conversation

jjyr
Copy link
Contributor

@jjyr jjyr commented May 23, 2019

Used in alert system #887

@jjyr jjyr requested a review from a team May 23, 2019 12:10
@nervos-bot
Copy link

nervos-bot bot commented May 23, 2019

@quake is assigned as the chief reviewer

@nervos-bot
Copy link

nervos-bot bot commented May 23, 2019

CI status of the fork branch is Build Status

doitian
doitian requested changes May 24, 2019
View reviewed changes
util/multisig/src/secp256k1.rs Outdated Show resolved Hide resolved
util/multisig/src/secp256k1.rs Outdated Show resolved Hide resolved
@jjyr jjyr force-pushed the secp256k1-multisig branch from 065379f to b28de98 Compare May 24, 2019 02:51
quake
quake requested changes May 24, 2019
View reviewed changes
util/multisig/src/secp256k1.rs Outdated Show resolved Hide resolved
util/multisig/src/secp256k1.rs Show resolved Hide resolved
@jjyr jjyr force-pushed the secp256k1-multisig branch from b28de98 to 1082572 Compare May 24, 2019 06:13
@jjyr jjyr requested review from doitian and quake and removed request for doitian May 24, 2019 06:14
@jjyr jjyr force-pushed the secp256k1-multisig branch from 1082572 to ae32969 Compare May 24, 2019 07:26
@jjyr jjyr requested a review from doitian May 24, 2019 07:33
doitian
doitian requested changes May 27, 2019
View reviewed changes
util/multisig/src/error.rs Outdated Show resolved Hide resolved
util/multisig/Cargo.toml Outdated Show resolved Hide resolved
@jjyr jjyr force-pushed the secp256k1-multisig branch from ae32969 to 05f17bc Compare May 28, 2019 03:33
@jjyr jjyr requested a review from doitian May 28, 2019 03:35
doitian
doitian reviewed May 28, 2019
View reviewed changes
util/multisig/src/error.rs Outdated Show resolved Hide resolved
@jjyr jjyr force-pushed the secp256k1-multisig branch from 05f17bc to c016987 Compare May 28, 2019 11:11
@jjyr jjyr force-pushed the secp256k1-multisig branch from c016987 to 8040170 Compare May 28, 2019 12:15
@jjyr jjyr merged commit 4a62641 into nervosnetwork:develop May 28, 2019
@jjyr jjyr deleted the secp256k1-multisig branch May 28, 2019 14:29
This was referenced Jun 3, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@doitian doitian doitian approved these changes

Assignees

@quake quake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjyr @quake @doitian