Add jsonrpc batch request limit #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
force-pushed
the
yukang-add-rpc-batch-limit
branch
from
2c62afe to
9fff036
Compare
eval-exec
reviewed
Jul 18, 2024
eval-exec
previously approved these changes
Jul 18, 2024
driftluo
reviewed
Jul 23, 2024
chenyukang
force-pushed
the
yukang-add-rpc-batch-limit
branch
2 times, most recently
from
fe6eb9e to
3fdccf9
Compare
chenyukang
force-pushed
the
yukang-add-rpc-batch-limit
branch
from
3fdccf9 to
9dd4ac2
Compare
zhangsoledad
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Partially address #4520
Problem Summary:
User may send large batch jsonrpc request, if the request costs much memory it may makes the ckb server hang up.
We should provide a way to support user to config the batch request limit.
jsonrpsee support this option, we can also support it with jsonrpc-utils.
What's Changed:
Related changes
owner/repo:Check List
Tests
Side effects
Release note