Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tx-pool): potential leaks when MaximumAncestors occurs #3698

Merged
merged 1 commit into from
Nov 11, 2022
Merged

fix(tx-pool): potential leaks when MaximumAncestors occurs #3698

merged 1 commit into from
Nov 11, 2022

Conversation

zhangsoledad
Copy link
Member

What problem does this PR solve?

Fix a potential issue where the transaction pool was not properly cleared of state when the MaximumAncestors limit was triggered

Check List

Tests

  • Unit test
  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad marked this pull request as ready for review November 10, 2022 08:24
@zhangsoledad zhangsoledad requested a review from a team as a code owner November 10, 2022 08:24
@zhangsoledad zhangsoledad requested review from quake and removed request for a team November 10, 2022 08:24
driftluo
driftluo approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@driftluo driftluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, the problem with the previous code was that the entry information was added to the deps before deciding whether the current entry could be inserted or not

@zhangsoledad
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 11, 2022

Build succeeded:

@bors bors bot merged commit 381932d into nervosnetwork:develop Nov 11, 2022
@doitian doitian mentioned this pull request Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@driftluo driftluo driftluo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangsoledad @quake @driftluo