fix: trace rpc #365
Merged
fix: trace rpc #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
zhangsoledad
force-pushed
the
zhangsoledad/fix_trace_api
branch
from
964ef96 to
c0992b1
Compare
zhangsoledad
requested review from
quake,
doitian and
jjyr
and removed request for
doitian
addition: * remove integration tests from root workspace * fix integration tests logger panic at flush
tryBuild failed
|
quake
approved these changes
Mar 27, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 27, 2019
365: fix: trace rpc r=quake a=zhangsoledad addition: * remove integration tests from root workspace * fix integration tests logger panic at flush Co-authored-by: zhangsoledad <[email protected]>
Build failed
|
|
Failed because of too many open files in macOS. |
doitian
approved these changes
Mar 28, 2019
|
default ulimit n is 256 on CI MacOS, it's too small, we may add |
zhangsoledad
force-pushed
the
zhangsoledad/fix_trace_api
branch
from
0cde006 to
eaaa2a3
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 28, 2019
365: fix: trace rpc r=zhangsoledad a=zhangsoledad addition: * remove integration tests from root workspace * fix integration tests logger panic at flush Co-authored-by: zhangsoledad <[email protected]>
Build succeeded
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addition: