feature: index whether a tx is a cellbase in the chain #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quake is refactoring the storage, we'll going to hold this PR. |
|
LGTM, however, I would like to hold this PR after #343 merged, and I will rebase this PR later. |
…he cellbase outputs maturity checking
updated |
quake
approved these changes
Mar 25, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 25, 2019
336: feature: index whether a tx is a cellbase in the chain r=quake a=u2 Index whether a tx is a cellbase in the chain, prepare for the cellbase outputs maturity checking. Now saving the cellbase index and block number in the `TransactionMeta`, there is another implementation which creates a `HashMap<tx_hash, number>`. The second one may be a little memory saving, but this one is more simple. I think both are ok. #54 Co-authored-by: u2 <[email protected]>
Build succeeded
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index whether a tx is a cellbase in the chain, prepare for the cellbase outputs maturity checking.
Now saving the cellbase index and block number in the
TransactionMeta, there is another implementation which creates aHashMap<tx_hash, number>. The second one may be a little memory saving, but this one is more simple. I think both are ok.#54