Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzing test for syscall exec #2961

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Fuzzing test for syscall exec #2961

merged 3 commits into from
Aug 26, 2021

Conversation

mohanson
Copy link
Contributor

@mohanson mohanson commented Aug 23, 2021

What problem does this PR solve?

Problem Summary:

Add fuzz test for exec syscall and fix the problems found in the test. Test results: https://github.com/mohanson/ckb_vm_exec_fuzz/tree/master/v1

What is changed and how it works?

What's Changed:

  • exec always return err code and Ok(true)
  • add bound check for exec's offset and length

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

None

@mohanson mohanson requested a review from a team as a code owner August 23, 2021 01:46
@mohanson mohanson requested review from quake and keroro520 August 23, 2021 01:46
@mohanson mohanson changed the title [WIP] Fuzzing test for syscall exec Fuzzing test for syscall exec Aug 25, 2021
Copy link
Member

@quake quake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, btw, is the out-of-bound issue catched by fuzz test?

@mohanson
Copy link
Contributor Author

mohanson commented Aug 26, 2021

LGTM, btw, is the out-of-bound issue catched by fuzz test?

By my new unit test check_exec_big_offset_length

@driftluo
Copy link
Collaborator

bors r=quake,driftluo

@bors
Copy link
Contributor

bors bot commented Aug 26, 2021

Build succeeded:

@bors bors bot merged commit 35aa766 into nervosnetwork:develop Aug 26, 2021
@mohanson mohanson deleted the execfuzz branch November 19, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants