test: fix integration test for backport #1169 #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xxuejie is assigned as the chief reviewer |
|
@nervos-bot-user try integration |
xxuejie
approved these changes
Jul 5, 2019
| specs.insert("chain_fork_5", Box::new(ChainFork5)); | ||
| specs.insert("chain_fork_6", Box::new(ChainFork6)); | ||
| specs.insert("chain_fork_7", Box::new(ChainFork7)); | ||
| // FIXME these 4 tests will fail, because of https://github.com/nervosnetwork/ckb/pull/1164 |
There was a problem hiding this comment.
I still think it's better to have 2 CI modes, one that could run on Travis but skip those tests, one runs on everything. The problem with commenting out, is that soon this might fail to build, and the most likely result would be those get deleted some time later. But I won't let those block merging.
doitian
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix integration test for backport #1169 and this PR needs backport to rc/v0.16