Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ᚬrc/v0.15.z] fix: Ban peer when validate received block failed #1164

Merged
merged 1 commit into from
Jul 3, 2019
Merged

[ᚬrc/v0.15.z] fix: Ban peer when validate received block failed #1164

merged 1 commit into from
Jul 3, 2019

Conversation

TheWaWaR
Copy link
Contributor

@TheWaWaR TheWaWaR commented Jul 3, 2019

No description provided.

@TheWaWaR TheWaWaR requested a review from a team July 3, 2019 06:49
@nervos-bot nervos-bot bot changed the title fix: Ban peer when validate received block failed [ᚬrc/v0.15.z] fix: Ban peer when validate received block failed Jul 3, 2019
@nervos-bot
Copy link

nervos-bot bot commented Jul 3, 2019

@zhangsoledad is assigned as the chief reviewer

@nervos-bot nervos-bot bot added the hotfix Fixing that must be submit to RC branch. label Jul 3, 2019
doitian
doitian reviewed Jul 3, 2019
View reviewed changes
Copy link
Member

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not pass network context around, but pop up the error instead.

@TheWaWaR
Copy link
Contributor Author

TheWaWaR commented Jul 3, 2019

I think we should not pass network context around, but pop up the error instead.

Agreed

@TheWaWaR TheWaWaR force-pushed the ban-peer-when-validate-failed branch from e95457c to 288f5d8 Compare July 3, 2019 07:53
@doitian doitian merged commit 839b2e5 into nervosnetwork:rc/v0.15.z Jul 3, 2019
@TheWaWaR TheWaWaR deleted the ban-peer-when-validate-failed branch August 1, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian left review comments

@quake quake quake approved these changes

@u2 u2 u2 approved these changes

@keroro520 keroro520 keroro520 approved these changes

Assignees

@zhangsoledad zhangsoledad

Labels
hotfix Fixing that must be submit to RC branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TheWaWaR @quake @doitian @u2 @keroro520 @zhangsoledad