Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct block number from tx_pool_excutor #1150

Merged

Conversation

keroro520
Copy link
Contributor

  • fix: The block number of the coming block should be tip_number + 1

NOTE: This is a breaking change

@keroro520 keroro520 added t:bug Type: This doesn't seem right. breaking change The feature breaks consensus, database, message schema or RPC interface. labels Jul 2, 2019
@keroro520 keroro520 requested review from jjyr and a team July 2, 2019 10:47
@nervos-bot nervos-bot bot assigned jjyr Jul 2, 2019
@nervos-bot
Copy link

nervos-bot bot commented Jul 2, 2019

@jjyr is assigned as the chief reviewer

@keroro520 keroro520 force-pushed the fix-txpool-excutor-block-number branch 2 times, most recently from c499653 to 3e70d5c Compare July 3, 2019 06:41
@keroro520 keroro520 force-pushed the fix-txpool-excutor-block-number branch from 3e70d5c to 45c69ad Compare July 4, 2019 09:57
@keroro520 keroro520 requested a review from jjyr July 4, 2019 09:57
@jjyr jjyr merged commit 8bb4cf2 into nervosnetwork:develop Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The feature breaks consensus, database, message schema or RPC interface. t:bug Type: This doesn't seem right.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants