feat: Remove rules of special reserve blocks #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quake is assigned as the chief reviewer |
doitian
changed the title
u2
reviewed
Jun 26, 2019
| (shared, chain1, chain2) | ||
| // the second chain must have smaller hash | ||
| if chain1.last().unwrap().header().hash() < chain2.last().unwrap().header().hash() { | ||
| (shared, chain2, chain1) |
There was a problem hiding this comment.
👍
It's better to add some comments for this function, not in this pr.
1 task
For block 1~11, the reward target is genesis block. Genesis block must have the lock serialized in the cellbase witness, which is set to `bootstrap_lock`.
doitian
added
breaking change
|
The most important change is in |
xxuejie
approved these changes
Jun 27, 2019
janx
reviewed
Jun 27, 2019
janx
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For block 1~11, the reward target is genesis block. Yes the reward for genesis is issued multiple times.
Genesis block must have the lock serialized in the cellbase witness, which is set to
bootstrap_lock.