More tests on ckb utils #1081
Merged
More tests on ckb utils #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doitian is assigned as the chief reviewer |
doitian
approved these changes
Jun 21, 2019
jjyr
force-pushed
the
more-tests-on-ckb-utils
branch
from
4a18a0e to
e47f41c
Compare
keroro520
reviewed
Jun 21, 2019
| AlertBuilder::default() | ||
| .id(1) | ||
| .max_version(Some("0.2.0".into())) | ||
| .min_version(Some("0.1.0".into())) |
There was a problem hiding this comment.
A question: max_version/min_version are declared as "String" type. Is it ok that "0.10.0" < "0.9.10"?
keroro520
approved these changes
Jun 21, 2019
jjyr
force-pushed
the
more-tests-on-ckb-utils
branch
from
e47f41c to
f5b5c07
Compare
zhangsoledad
approved these changes
Jun 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.