Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add an extra cost for dynamic length types #1055

Merged
merged 3 commits into from
Jun 18, 2019
Merged

feat: add an extra cost for dynamic length types #1055

merged 3 commits into from
Jun 18, 2019

Conversation

chaoticlonghair
Copy link
Contributor

@chaoticlonghair chaoticlonghair commented Jun 18, 2019 •
edited
Loading

BREAKING CHANGE:

  • The occupied capacity for dynamic length types is changed, and some data and hashes have to be updated.
  • The serialized size for dynamic length types is changed.

@chaoticlonghair
feat: add an extra cost of occupied capacity for dynamic length types
3ecf446 
BREAKING CHANGE: The occupied capacity for dynamic length types is changed, and some data and hashes
have to be updated.
@chaoticlonghair chaoticlonghair requested a review from a team June 18, 2019 10:14
@nervos-bot nervos-bot bot added the breaking change The feature breaks consensus, database, message schema or RPC interface. label Jun 18, 2019
@nervos-bot
Copy link

nervos-bot bot commented Jun 18, 2019

@keroro520 is assigned as the chief reviewer

@doitian doitian added the b:consensus Break consensus label Jun 18, 2019
@doitian
Copy link
Member

doitian commented Jun 18, 2019

cc @ashchan @classicalliu

doitian
doitian requested changes Jun 18, 2019
View reviewed changes
Copy link
Member

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case to show how many capacities an empty data cell with secp256k1 lock occupied?

@doitian

This comment has been minimized.

Sign in to view
@doitian
Copy link
Member

doitian commented Jun 18, 2019 •
edited
Loading

This change should also be applied serialized_size. But it can be sent in a new PR.

@chaoticlonghair chaoticlonghair requested a review from doitian June 18, 2019 13:50
@chaoticlonghair chaoticlonghair changed the title feat: add an extra cost of occupied capacity for dynamic length types feat: add an extra cost for dynamic length types Jun 18, 2019
@doitian doitian merged commit 6e484d0 into nervosnetwork:develop Jun 18, 2019
This was referenced Jun 21, 2019
Closed
Merged
@chaoticlonghair chaoticlonghair deleted the pr/extra-cost branch August 30, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@jjyr jjyr jjyr approved these changes

Assignees

@keroro520 keroro520

Labels
b:consensus Break consensus breaking change The feature breaks consensus, database, message schema or RPC interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaoticlonghair @doitian @jjyr @keroro520