Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ckb init allow set ba-data #1035

Merged
merged 2 commits into from
Jun 18, 2019
Merged

feat: ckb init allow set ba-data #1035

merged 2 commits into from
Jun 18, 2019

Conversation

driftluo
Copy link
Collaborator

  1. ckb init allow set ba-data
  2. Verify that the input is valid hex

@driftluo driftluo requested a review from a team June 16, 2019 03:19
@nervos-bot
Copy link

nervos-bot bot commented Jun 16, 2019

@yangby-cryptape is assigned as the chief reviewer

@driftluo driftluo mentioned this pull request Jun 16, 2019
Closed
doitian
doitian requested changes Jun 16, 2019
View reviewed changes
ckb-bin/src/subcommand/init.rs Outdated Show resolved Hide resolved
util/app-config/src/cli.rs Outdated Show resolved Hide resolved
quake
quake previously requested changes Jun 16, 2019
View reviewed changes
util/app-config/src/cli.rs Outdated Show resolved Hide resolved
util/app-config/src/cli.rs Outdated Show resolved Hide resolved
@doitian doitian requested a review from quake June 18, 2019 04:54
@doitian doitian merged commit 169bbbc into nervosnetwork:develop Jun 18, 2019
@driftluo driftluo deleted the init-ba-data branch June 18, 2019 05:13
This was referenced Jun 21, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@keroro520 keroro520 keroro520 approved these changes

@chaoticlonghair chaoticlonghair chaoticlonghair approved these changes

@quake quake Awaiting requested review from quake

Assignees

@chaoticlonghair chaoticlonghair

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@driftluo @quake @doitian @keroro520 @chaoticlonghair