-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(storage): use flatbuffer instead of bincode in storage #1032
Merged
chaoticlonghair
merged 7 commits into
nervosnetwork:develop
from
chaoticlonghair:pr/fb-storage
Jun 25, 2019
Merged
refactor(storage): use flatbuffer instead of bincode in storage #1032
chaoticlonghair
merged 7 commits into
nervosnetwork:develop
from
chaoticlonghair:pr/fb-storage
Jun 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df08d9a
to
be00113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold as requested by @doitian.
This will not be included in v0.15.0. Hold until 0.15.0 RC. |
be00113
to
e9d2ac6
Compare
This comment has been minimized.
This comment has been minimized.
e9d2ac6
to
f75ea22
Compare
@keroro520: |
This comment has been minimized.
This comment has been minimized.
5af7311
to
9b52562
Compare
quake
approved these changes
Jun 22, 2019
…art 1) BREAKING CHANGE: the data format in storage is changed
…art 2) BREAKING CHANGE: the data format in storage is changed
…art 3) BREAKING CHANGE: the data format in storage is changed
…art 4) BREAKING CHANGE: the data format in storage is changed
9b52562
to
6274c41
Compare
This comment has been minimized.
This comment has been minimized.
driftluo
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
b:database
Break database schema
breaking change
The feature breaks consensus, database, message schema or RPC interface.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issues
Description
I use
flatbuffer
, notcfb
. We can do it later.I copy some code from
ckb-protocol
, not just use it, because:Since the data is from local storage, we can ensure the data format shouldn't be malformed.
Do
expect(..)
is safety for storage, but not safety for network.I try to split those proto-types into different schemas, classify them according to their usages.
If required, we can rewrite proto-types for storage, and don't have to modify proto-types for network.
I rewrite some of them.
I just remove
bincode
fromckb-store
, but I keep thebincode
for computing hashes. We can do it later.I can't remove
serde
fromckb-core
, because:ckb/chain/src/chain.rs
Lines 58 to 60 in 99dd90e
ckb/util/instrument/src/import.rs
Line 69 in 99dd90e
A few log outputs.
I think we should use
jsonrpc-types
for importing and exporting jsons and useDisplay
for log outputs.Then we can remove
serde
fromckb-core
.BREAKING CHANGE
The data format in storage is changed.