Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ckb run Automatically Creates default.db-options if Missing in data_dir #4671

Closed
eval-exec opened this issue Oct 8, 2024 · 2 comments · Fixed by #4700
Closed

Ensure ckb run Automatically Creates default.db-options if Missing in data_dir #4671

eval-exec opened this issue Oct 8, 2024 · 2 comments · Fixed by #4700
Labels
t:enhancement Type: Feature, refactoring.

Comments

@eval-exec
Copy link
Collaborator

Feature Request

Is your feature request related to a problem? Please describe.

When running ckb run, it would be ideal if the absence of the default.db-options file in the data_dir doesn't prevent the launch. It might be best for ckb run to check if the default.db-options file exists in data_dir during the initialization process, and if not, create it automatically.

Describe the solution you'd like

create default.db-options file automatically if it doesn't exists.
@eval-exec eval-exec added the t:enhancement Type: Feature, refactoring. label Oct 8, 2024
@eval-exec eval-exec changed the title Initialize a default default.db-options file after ckb run? Ensure ckb run Automatically Creates default.db-options if Missing in data_dir Oct 8, 2024
@eval-exec eval-exec changed the title Ensure ckb run Automatically Creates default.db-options if Missing in data_dir Ensure ckb run Automatically Creates default.db-options if Missing in data_dir Oct 8, 2024
@eval-exec eval-exec changed the title Ensure ckb run Automatically Creates default.db-options if Missing in data_dir Ensure ckb run Automatically Creates default.db-options if Missing in data_dir Oct 8, 2024
eval-exec added a commit to eval-exec/ckb that referenced this issue Oct 28, 2024
@eval-exec
Generate default.db-options file if it not exist, nervosnetwork#4671
03ce485
eval-exec added a commit to eval-exec/ckb that referenced this issue Oct 28, 2024
@eval-exec
Generate default.db-options file if it not exist, nervosnetwork#4671
d06619f 
Signed-off-by: Eval EXEC <[email protected]>
@eval-exec eval-exec mentioned this issue Oct 28, 2024
Merged
eval-exec added a commit to eval-exec/ckb that referenced this issue Oct 28, 2024
@eval-exec
Generate default.db-options file if it not exist, nervosnetwork#4671
387b994 
Signed-off-by: Eval EXEC <[email protected]>
eval-exec added a commit to eval-exec/ckb that referenced this issue Oct 28, 2024
@eval-exec
Generate default.db-options file if it not exist, nervosnetwork#4671
05da01d 
Signed-off-by: Eval EXEC <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale To be closed due to a lack of activity label Nov 8, 2024
@github-actions GitHub Actions
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
eval-exec added a commit to eval-exec/ckb that referenced this issue Nov 13, 2024
@eval-exec
Generate default.db-options file if it not exist, nervosnetwork#4671
408b378 
Signed-off-by: Eval EXEC <[email protected]>
@eval-exec eval-exec reopened this Nov 13, 2024
eval-exec added a commit to eval-exec/ckb that referenced this issue Nov 13, 2024
@eval-exec
Generate default.db-options file if it not exist, nervosnetwork#4671
ece18e5 
Signed-off-by: Eval EXEC <[email protected]>
@github-actions github-actions bot removed the stale To be closed due to a lack of activity label Nov 14, 2024
eval-exec added a commit to eval-exec/ckb that referenced this issue Nov 14, 2024
@eval-exec
Generate default.db-options file if it not exist, nervosnetwork#4671
d750782 
Signed-off-by: Eval EXEC <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t:enhancement Type: Feature, refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate default.db-options file if it not exist eval-exec/ckb
1 participant
@eval-exec