Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename RPC get_cells_by_type_hash -> get_cells_by_lock_hash #225

Closed
nervos-bot bot opened this issue Jan 24, 2019 · 1 comment
Closed

Rename RPC get_cells_by_type_hash -> get_cells_by_lock_hash #225

nervos-bot bot opened this issue Jan 24, 2019 · 1 comment
Assignees
@xxuejie
Labels
s:triage Status: This issue is pending to decide the next step.

Comments

@nervos-bot
Copy link

nervos-bot bot commented Jan 24, 2019 •
edited by doitian
Loading

ckb/rpc/src/module/chain.rs

Line 64 in 3dcbefa

fn get_cells_by_type_hash(

@doitian doitian added the s:triage Status: This issue is pending to decide the next step. label Jan 24, 2019
@ashchan
Copy link
Contributor

ashchan commented Mar 29, 2019

This was implemented via #344.

@doitian doitian closed this as completed Mar 29, 2019
bors bot added a commit that referenced this issue May 1, 2020
@bors @driftluo @chaoticlonghair
Merge #2050 #2053
f27ed20 
2050: chore: upgrade p2p/tokio r=TheWaWaR,quake a=driftluo

1. Upgrade p2p, use new `BlockingFlag` to optimize performance
2. Upgrade tokio, allow recursive call `block_in_place`

p2p release note:
```
Bug Fix

    Fix session proto open/close by user part(#220)

Features

    Replace unsplit with assignment(#225)
    Upgrade tokio util(#224)
    Avoids unnecessary session id checking(#223)
    Check all underscore(#228)
    Use flag to control how to use block_in_place(#226)
    More test(#227/#220)
```

tokio release note:
```
Fix
    rt: support block_in_place in more contexts
    stream: no panic in merge() and chain() when using size_hint()
    task: include visibility modifier when defining a task-local
    sync: broadcast closing the channel no longer requires capacity 

Added
    rt: runtime::Handle::block_on
```

2053: test: save integration test logs in a specified directory r=keroro520,doitian a=yangby-cryptape

Currently, it's too hard to distinguish between integration test logs and other temporary logs, especially when make integration test to be automated.

Co-authored-by: driftluo <[email protected]>
Co-authored-by: Boyu Yang <[email protected]>
bors bot added a commit that referenced this issue May 1, 2020
@bors @driftluo
Merge #2050
e492116 
2050: chore: upgrade p2p/tokio r=TheWaWaR,quake a=driftluo

1. Upgrade p2p, use new `BlockingFlag` to optimize performance
2. Upgrade tokio, allow recursive call `block_in_place`

p2p release note:
```
Bug Fix

    Fix session proto open/close by user part(#220)

Features

    Replace unsplit with assignment(#225)
    Upgrade tokio util(#224)
    Avoids unnecessary session id checking(#223)
    Check all underscore(#228)
    Use flag to control how to use block_in_place(#226)
    More test(#227/#220)
```

tokio release note:
```
Fix
    rt: support block_in_place in more contexts
    stream: no panic in merge() and chain() when using size_hint()
    task: include visibility modifier when defining a task-local
    sync: broadcast closing the channel no longer requires capacity 

Added
    rt: runtime::Handle::block_on
```

Co-authored-by: driftluo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xxuejie xxuejie

Labels
s:triage Status: This issue is pending to decide the next step.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashchan @doitian @xxuejie