Add spawn syscalls for ckb2023 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxuejie
reviewed
Apr 21, 2023
ckb_syscalls.h
Outdated
| @@ -377,6 +377,47 @@ int ckb_exec_cell(const uint8_t* code_hash, uint8_t hash_type, uint32_t offset, | |||
| argv); | |||
| } | |||
|
|
|||
| typedef struct { | |||
There was a problem hiding this comment.
What about exposing this data structure directly? In general having too many arguments in C(I'm counting 9 or 10 below) is not a good thing.
There was a problem hiding this comment.
I redesigned the API, now it takes fewer parameters
XuJiandong
requested changes
Apr 25, 2023
XuJiandong
requested changes
Apr 25, 2023
XuJiandong
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: https://github.com/nervosnetwork/ckb/blob/ckb2023/script/src/verify/tests/ckb_latest/features_since_v2023.rs
Note: The modification of
ckb_utils.hcomes from the commandmake fmt