Assign safer AP mode IP address #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 172.16.61.0 instead of 192.168.0.0 since it is less likely to conflict with LANs SRH-747
jfcloutier
force-pushed
the
no_ap_mode_ip_conflict
branch
from
e3a255e to
b2c8661
Compare
fhunleth
reviewed
May 10, 2023
| @@ -8,21 +8,21 @@ defmodule VintageNetWizard.APModeTest do | |||
|
|
|||
| expected = %{ | |||
| type: VintageNetWiFi, | |||
| ipv4: %{address: {192, 168, 0, 1}, method: :static, prefix_length: 24}, | |||
| ipv4: %{address: {172, 16, 61, 0}, method: :static, prefix_length: 24}, | |||
There was a problem hiding this comment.
Suggested change
| ipv4: %{address: {172, 16, 61, 0}, method: :static, prefix_length: 24}, | |
| ipv4: %{address: {172, 16, 61, 1}, method: :static, prefix_length: 24}, |
The references below need to have the .1 in them too.
|
Superseded by #318. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 172.16.61.0 instead of 192.168.0.0
since it is less likely to conflict with LANs
SRH-747