Fix org_certificate_controller :edit cannot render

apps/nerves_hub_www/lib/nerves_hub_www_web/templates/org_certificate/edit.html.heex

@@ -9,9 +9,9 @@
 
   <%= inputs_for f, :jitp, fn fp -> %>
     <label for="jitp_toggle"> Enable Just In Time Provisioning </label>
-    <input type="checkbox" name="jitp_toggle" id="jitp_toggle" checked={f.data.jitp}>
+    <input type="checkbox" name="jitp_toggle" id="jitp_toggle" checked={not is_nil(f.data.jitp)}>
     <%= hidden_input fp, :delete, id: "jitp-delete" %>
-    <div hidden={!f.data.jitp} id="jitp_form">
+    <div hidden={is_nil(f.data.jitp)} id="jitp_form">
       <div class="form-group">
         <label for="description_input" class="tooltip-label h3 mb-1">
           <span>JITP Description</span>

apps/nerves_hub_www/test/nerves_hub_www_web/controllers/org_certificate_controller_test.exs

@@ -173,7 +173,28 @@ defmodule NervesHubWWWWeb.OrgCertificateControllerTest do
     test "renders form", %{conn: conn, org: org} do
       %{db_cert: ca} = Fixtures.ca_certificate_fixture(org)
       conn = get(conn, Routes.org_certificate_path(conn, :edit, org.name, ca.serial))
-      assert html_response(conn, 200) =~ "Edit Certificate Authority"
+
+      html = html_response(conn, 200)
+      assert html =~ "Edit Certificate Authority"
+
+      assert html
+             |> Floki.parse_document!()
+             |> Floki.find("#jitp_form")
+             |> Floki.attribute("hidden") == ["hidden"]
+    end
+
+    test "renders form, jitp enabled", %{conn: conn, org: org, user: user} do
+      product = Fixtures.product_fixture(user, org)
+      %{db_cert: ca} = Fixtures.ca_certificate_jitp_enabled_fixture(org, product)
+      conn = get(conn, Routes.org_certificate_path(conn, :edit, org.name, ca.serial))
+
+      html = html_response(conn, 200)
+      assert html =~ "Edit Certificate Authority"
+
+      assert html
+             |> Floki.parse_document!()
+             |> Floki.find("#jitp_form")
+             |> Floki.attribute("hidden") == []
     end
 
     test "redirects to index when not found", %{conn: conn, org: org} do

test/support/fixtures.ex

@@ -124,24 +124,41 @@ defmodule NervesHubWebCore.Fixtures do
     org_key
   end
 
-  def ca_certificate_fixture(%Accounts.Org{} = org, opts \\ []) do
-    opts = Keyword.merge([template: :root_ca], opts)
-    ca_key = X509.PrivateKey.new_ec(:secp256r1)
-    ca = X509.Certificate.self_signed(ca_key, "CN=#{org.name}", opts)
-
+  defp to_ca_certificate_params(ca) do
     {not_before, not_after} = NervesHubWebCore.Certificate.get_validity(ca)
 
     serial = NervesHubWebCore.Certificate.get_serial_number(ca)
     aki = NervesHubWebCore.Certificate.get_aki(ca)
 
-    params = %{
+    %{
       serial: serial,
       aki: aki,
       ski: NervesHubWebCore.Certificate.get_ski(ca),
       not_before: not_before,
       not_after: not_after,
       der: X509.Certificate.to_der(ca)
     }
+  end
+
+  def ca_certificate_fixture(%Accounts.Org{} = org, opts \\ []) do
+    opts = Keyword.merge([template: :root_ca], opts)
+    ca_key = X509.PrivateKey.new_ec(:secp256r1)
+    ca = X509.Certificate.self_signed(ca_key, "CN=#{org.name}", opts)
+
+    params = to_ca_certificate_params(ca)
+
+    {:ok, db_cert} = Devices.create_ca_certificate(org, params)
+    %{cert: ca, key: ca_key, db_cert: db_cert}
+  end
+
+  def ca_certificate_jitp_enabled_fixture(%Accounts.Org{} = org, %Product{} = product, opts \\ []) do
+    opts = Keyword.merge([template: :root_ca], opts)
+    ca_key = X509.PrivateKey.new_ec(:secp256r1)
+    ca = X509.Certificate.self_signed(ca_key, "CN=#{org.name}", opts)
+
+    params =
+      to_ca_certificate_params(ca)
+      |> Map.put(:jitp, %{"description" => "jitp", "product_id" => product.id, "tags" => ["prod"]})
 
     {:ok, db_cert} = Devices.create_ca_certificate(org, params)
     %{cert: ca, key: ca_key, db_cert: db_cert}