Add device count and estimated device count for Deployment views #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawik
force-pushed
the
deployment-views-nice-counts
branch
from
7426761 to
cbef6d6
Compare
joshk
requested changes
Sep 14, 2024
lawik
force-pushed
the
deployment-views-nice-counts
branch
from
cbef6d6 to
5b6e1af
Compare
|
Gotta make it not break also... |
This allows seeing how big a deployment is in device count in listings and detail view. Beyond that the Edit form for Deployments will estimate the matching devices based on the conditions set.
lawik
force-pushed
the
deployment-views-nice-counts
branch
from
5b6e1af to
f8a4870
Compare
|
And fixed :D |
|
Test hit a deadlock in an unrelated test so I gave it a re-run. Worth figuring out but very unlikely to be this PR? |
joshk
reviewed
Sep 25, 2024
Possibly but not enough that I think anyone would care if it broke and it would take kind of weird stuff to break it. You can make a call on this. I'll write the tests if you prefer them. For me they are smack in the do/don't split. |
|
Same, this is smack bang on that line. I'm going to skip the need for a test as we are looking at making changes to Deployments in the long run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows seeing how big a deployment is in device count in listings
and detail view.
Beyond that the Edit form for Deployments will estimate the matching
devices based on the conditions set.