Update Elixir 1.17.2 / OTP 27.0.1 #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to support devices using OTP 27.0.1 (using `nerves_system_br`
>= 1.28.2).
OTP 27.0 was missing some handling of `ecdsa` signature algs for certificates
and would only allow `SHA1` for ecdsa certs. Device Certificates connecting
to NervesHub typically use `{:sha256, :ecdsa}` which would not match when
comparing allowed `:signature_algs_cert` option of the incoming client hello.
This was fixed as part of erlang/otp#8588 via
[`e57bfe6d`](erlang/otp@e57bfe6#diff-519ed7d3ffd869a0cf148a8b2fb6136d280147fa1d5c2aa6496a8fd2fc7ad188R1747-R1749)
to support checking mutliple `:ecdsa` options
fhunleth
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support devices using OTP 27.0.1 (using
nerves_system_brOTP 27.0 was missing some handling of
ecdsasignature algs for certificates and would only allowSHA1for ecdsa certs. Device Certificates connecting to NervesHub typically use{:sha256, :ecdsa}which would not match when comparing allowed:signature_algs_certoption of the incoming client hello.This was fixed as part of erlang/otp#8588 via
e57bfe6dto support checking mutliple:ecdsaoptions