Fix test for Python >=3.11, caused by missing default_factory

nerfstudio-project · Jan 21, 2025 · 1491e89 · 1491e89
1 parent 9554a2a
commit 1491e89
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/docs/developer_guides/new_methods.md b/docs/developer_guides/new_methods.md
@@ -83,7 +83,7 @@ The `NERFSTUDIO_METHOD_CONFIGS` environment variable additionally accepts a func
 ```python
 """my_method/my_config.py"""
 
-from dataclasses import dataclass
+from dataclasses import dataclass, field
 from nerfstudio.engine.trainer import TrainerConfig
 from nerfstudio.plugins.types import MethodSpecification
 
@@ -95,7 +95,7 @@ def MyMethodFunc():
 
 @dataclass
 class MyMethodClass(MethodSpecification):
-    config: TrainerConfig = TrainerConfig(...)
+    config: TrainerConfig = field(default_factory=lambda: TrainerConfig(...))
     description: str = "Custom description"
 ```
 

diff --git a/tests/plugins/test_registry.py b/tests/plugins/test_registry.py
@@ -20,10 +20,12 @@
 
 @dataclass
 class TestConfigClass(MethodSpecification):
-    config: TrainerConfig = TrainerConfig(
-        method_name="test-method",
-        pipeline=VanillaPipelineConfig(),
-        optimizers={},
+    config: TrainerConfig = field(
+        default_factory=lambda: TrainerConfig(
+            method_name="test-method",
+            pipeline=VanillaPipelineConfig(),
+            optimizers={},
+        )
     )
     description: str = "Test description"