fix: ensure latest previous position value is used to determine when …

…to use position prop
nerdyman · Feb 23, 2020 · fb8d7cd · fb8d7cd
1 parent 1604a0f
commit fb8d7cd
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/react-compare-slider.tsx b/src/react-compare-slider.tsx
@@ -183,9 +183,7 @@ export const ReactCompareSlider: React.FC<ReactCompareSliderProps &
       x: (width / 100) * position,
       y: (height / 100) * position,
     });
-    // `prevPropsPosition` is a ref value so it shouldn't been in deps
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [position, updateInternalPosition]);
+  }, [position, prevPropsPosition, updateInternalPosition]);
 
   /** Handle mouse/touch down */
   const handlePointerDown = useCallback(