Skip to content

Commit

Permalink
refactor: use This prefix for internal components
Browse files Browse the repository at this point in the history
  • Loading branch information
nerdyman committed Dec 13, 2020
1 parent af254cf commit fa1858a
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 36 deletions.
35 changes: 27 additions & 8 deletions src/ReactCompareSlider.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React, { forwardRef, useEffect, useCallback, useRef, useState } from 'react';

import { ReactCompareSliderHandle } from './ReactCompareSliderHandle';
import { ReactCompareSliderClipContainer } from './ReactCompareSliderClipContainer';
import { ReactCompareSliderCommonProps, ReactCompareSliderPropPosition } from './types';

import {
Expand All @@ -11,8 +10,30 @@ import {
useResizeObserver,
} from './utils';

/** Container for clipped item. */
const ThisClipContainer = forwardRef<HTMLDivElement, React.HTMLProps<HTMLDivElement>>(
(props, ref): React.ReactElement => {
const style: React.CSSProperties = {
position: 'absolute',
top: 0,
left: 0,
width: '100%',
height: '100%',
willChange: 'clip',
userSelect: 'none',
KhtmlUserSelect: 'none',
MozUserSelect: 'none',
WebkitUserSelect: 'none',
};

return <div {...props} style={style} data-rcs="clip-item" ref={ref} />;
}
);

ThisClipContainer.displayName = 'ThisClipContainer';

/** Handle container to control position. */
const ReactCompareSliderHandleContainer = forwardRef<
const ThisHandleContainer = forwardRef<
HTMLDivElement,
React.HTMLProps<HTMLDivElement> & Pick<ReactCompareSliderCommonProps, 'portrait'>
>(
Expand Down Expand Up @@ -41,7 +62,7 @@ const ReactCompareSliderHandleContainer = forwardRef<
}
);

ReactCompareSliderHandleContainer.displayName = 'ReactCompareSliderHandleContainer';
ThisHandleContainer.displayName = 'ThisHandleContainer';

/** Comparison slider properties. */
export interface ReactCompareSliderProps extends Partial<ReactCompareSliderCommonProps> {
Expand Down Expand Up @@ -334,12 +355,10 @@ export const ReactCompareSlider: React.FC<
return (
<div {...props} ref={rootContainerRef} style={rootStyle} data-rcs="root">
{itemTwo}
<ReactCompareSliderClipContainer ref={clipContainerRef}>
{itemOne}
</ReactCompareSliderClipContainer>
<ReactCompareSliderHandleContainer portrait={portrait} ref={handleContainerRef}>
<ThisClipContainer ref={clipContainerRef}>{itemOne}</ThisClipContainer>
<ThisHandleContainer portrait={portrait} ref={handleContainerRef}>
{Handle}
</ReactCompareSliderHandleContainer>
</ThisHandleContainer>
</div>
);
};
28 changes: 0 additions & 28 deletions src/ReactCompareSliderClipContainer.tsx

This file was deleted.

1 change: 1 addition & 0 deletions src/ReactCompareSliderHandle.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import React from 'react';
import { ReactCompareSliderCommonProps } from './types';

interface ThisArrowProps {
/** Whether to flip the arrow direction. */
flip?: boolean;
}

Expand Down

0 comments on commit fa1858a

Please sign in to comment.