fix: move aria-label to handle container button element, closes #130

nerdyman · Feb 8, 2024 · 54a715c · 54a715c
1 parent 0353d78
commit 54a715c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/lib/src/Container.tsx b/lib/src/Container.tsx
@@ -54,6 +54,7 @@ export const ContainerHandle = forwardRef<
   return (
     <button
       ref={ref}
+      aria-label="Drag to move or focus and use arrow keys"
       aria-orientation={portrait ? 'vertical' : 'horizontal'}
       aria-valuemin={0}
       aria-valuemax={100}

diff --git a/lib/src/ReactCompareSliderHandle.tsx b/lib/src/ReactCompareSliderHandle.tsx
@@ -86,12 +86,7 @@ export const ReactCompareSliderHandle: FC<
   };
 
   return (
-    <div
-      {...props}
-      aria-label={props['aria-label'] || 'Drag to move'}
-      className={className}
-      style={_style}
-    >
+    <div {...props} className={className} style={_style}>
       <div className="__rcs-handle-line" style={_linesStyle} />
       <div className="__rcs-handle-button" style={_buttonStyle}>
         <ThisArrow />