[FEATURE] 최초 로그인 시 회원가입 로직 구현과 닉네임 수정 기능 구현 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 클라이언트 닉네임 수정 기능이 추가됨에 따라 닉네임 수정 로직을 추가했습니다. - 모바일의 경우 클라이언트에서 최초 로그인 시, 추가 정보를 입력받는 화면을 구현했고 그에 따라 서버도 회원가입 로직을 로그인에서 분리했습니다. > 웹에서 로그인 시에는 기존과 동일하게 자동 회원가입 합니다. - `User` 도메인 subId와 email 에 unique 속성을 줬습니다.
JakePark929
requested review from
BellaChooi,
parkjinhyun2 and
donsonioc2010
as code owners
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR Summary
처음 이슈 발행 때 만해도 이 부분은 어떻게 구현해야 될지 막막했는데
클라이언트에서 로그인과 사용자 정보 구현하면서 보니 방법이 떠올라서
같이 구현했는데 잘 구현된 것 같아서 좋네요! 리뷰 잘 부탁 드려요~
User도메인 subId와 email 에 unique 속성을 줬습니다.🌲 Working Branch
feat/#11-signup
🌲 TODOs
Related Issues
resolves #11