Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basket Cover Pools #84

Merged
merged 55 commits into from
Jun 29, 2022
Merged

Basket Cover Pools #84

merged 55 commits into from
Jun 29, 2022

Conversation

heyaibi
Copy link
Contributor

@heyaibi heyaibi commented Jun 8, 2022

Work in progress. Please do not merge.

heyaibi and others added 30 commits April 13, 2022 16:11
- Refactored to charge platform fee during cover purchase
Work in progress. Please do not merge.
- Updated some documentation
- Refactored tests
…ing stake for individual covers

- Refactored test
- Added documetation
- Updated ABIs and keys
Refactored the Cover contract to restrict cover and product updates during withdrawal period. Changed the role from cover owner or admin to cover manager.
flashburst and others added 25 commits June 13, 2022 18:17
Dropped Compound DAI delegator
- Replaced hardhat console.log statements using events
- Dropped redundant usage of `NTransferUtilV2` library
- Added documentation
- Minor refactors
- Fixed incorrect revert reason on `NTransferUtilV2.ensureApproval`
- Refactored tests
Fixed cover and product status validations
@heyaibi heyaibi marked this pull request as ready for review June 29, 2022 19:48
@heyaibi heyaibi merged commit 1d01f0b into develop Jun 29, 2022
@flashburst flashburst linked an issue Jun 30, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About updating cover rules
2 participants