Refactor #13
Merged
Refactor #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added functions `addContractWithKey`, `upgradeContractWithKey`, and `grantRoles` to Protocol - Refactored `cxToken` constructor to fix Etherscan verification issue. Refactored `cxTokenFactory` and `ICxTokenFactory` accordingly. - Removed the requirement of `cxToken` being a member of the protocol - Refactored `VaultDelegateBase` - Fixed solhint and slither issues - Refactored `removeLiquidity` of the Vault contract to only emit `NPMUnstaken` when the value is greater than zero - Renamed the function `getStablecoinBalanceOfCoverPoolInternal` and `getCoverPoolLiquidity` to `getStablecoinOwnedByVaultInternal` - Renamed the function `getCoverLiquidityCommitted` to `getActiveLiquidityUnderProtection` - Dropped obsolete contract interface `ICommission` - Moved `addContractInternal`, `upgradeContractInternal`, `addMemberInternal`, `removeMemberInternal` to `AccessControlLibV1` from `ProtoUtilV1` - To avoid confusion, refactored BondPool’s function `_getCommitment` to `_getBondCommitment` - Refactored `PolicyHelperV1` and dropped obsolete functions `_setCommitments`, `getCommitmentInternal`, and `getStablecoinBalanceOfCoverPoolInternal` - Added function `deleteAddressByKeys` to `StoreKeyUtil` - Added a check to ensure that `calculatePodsInternal` is not called during flash lending transactions - Refactored unit tests - Refactored deployment script, composer, and utils - Updated ABIs - Updated documentation - Updated keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addContractWithKey,upgradeContractWithKey, andgrantRolesto ProtocolcxTokenconstructor to fix Etherscan verification issue. RefactoredcxTokenFactoryandICxTokenFactoryaccordingly.cxTokenbeing a member of the protocolVaultDelegateBaseremoveLiquidityof the Vault contract to only emitNPMUnstakenwhen the value is greater than zerogetStablecoinBalanceOfCoverPoolInternalandgetCoverPoolLiquiditytogetStablecoinOwnedByVaultInternalgetCoverLiquidityCommittedtogetActiveLiquidityUnderProtectionICommissionaddContractInternal,upgradeContractInternal,addMemberInternal,removeMemberInternaltoAccessControlLibV1fromProtoUtilV1_getCommitmentto_getBondCommitmentPolicyHelperV1and dropped obsolete functions_setCommitments,getCommitmentInternal, andgetStablecoinBalanceOfCoverPoolInternaldeleteAddressByKeystoStoreKeyUtilcalculatePodsInternalis not called during flash lending transactions