Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validations #100

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Validations #100

merged 1 commit into from
Jun 30, 2022

Conversation

heyaibi
Copy link
Contributor

@heyaibi heyaibi commented Jun 29, 2022

  • Refactored addDisputeInternal to addRefutationInternal
  • Added a check mustNotExceedProposalThreshold to purchaseCover
  • Refactored tests

- Refactored addDisputeInternal to addRefutationInternal
d18a82c 
- Added a check `mustNotExceedProposalThreshold` to `purchaseCover`
- Refactored tests
@heyaibi heyaibi marked this pull request as ready for review June 29, 2022 19:56
@heyaibi heyaibi requested review from flashburst and rudolfnep June 29, 2022 19:56
@heyaibi heyaibi removed the request for review from flashburst June 30, 2022 09:11
@heyaibi heyaibi merged commit f73c24b into feature/basket-cover Jun 30, 2022
@heyaibi heyaibi deleted the fix/validations branch June 30, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flashburst flashburst flashburst approved these changes

@rudolfnep rudolfnep rudolfnep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyaibi @flashburst @rudolfnep