Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OZ] L-05 Incorrect NPM threshold #148

Closed
heyaibi opened this issue Sep 3, 2022 · 0 comments · Fixed by #164
Closed

[OZ] L-05 Incorrect NPM threshold #148

heyaibi opened this issue Sep 3, 2022 · 0 comments · Fixed by #164
Assignees
@flashburst
Labels
bug Something isn't working confirmed open-zeppelin-audit rc2

Comments

@heyaibi
Copy link
Contributor

heyaibi commented Sep 3, 2022

Please note that OpenZeppelin reported this issue.

Some operations require an NPM stake that must not exceed a threshold, currently set to 10 billion. However, the total NPM supply cannot exceed 1 billion, making the threshold nonfunctional. The Neptune team indicated the threshold should only be 10 million. Consider updating the constant accordingly.
flashburst added a commit that referenced this issue Sep 6, 2022
@flashburst
Fixes Issue #148 - Incorrect NPM threshold
78fafa7 
Updated thresholds to 10 million - `MAX_LIQUIDITY`, `MAX_PROPOSAL_AMOUNT` and `MAX_NPM_STAKE`
@flashburst flashburst linked a pull request Sep 6, 2022 that will close this issue
Fixes Issue #148 - Incorrect NPM threshold #164
Merged
heyaibi added a commit that referenced this issue Sep 6, 2022
@heyaibi
Merge pull request #164 from neptune-mutual-blue/fix/token-threshold
be8c00b 
Fixes Issue #148 - Incorrect NPM threshold
@heyaibi heyaibi closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flashburst flashburst

Labels
bug Something isn't working confirmed open-zeppelin-audit rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Issue #148 - Incorrect NPM threshold neptune-mutual-blue/protocol
2 participants
@heyaibi @flashburst